dangogh closed pull request #2598: comments out cachegroup apis that were not
implemented correctly. the…
URL: https://github.com/apache/trafficcontrol/pull/2598
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/traffic_ops/traffic_ops_golang/routes.go
b/traffic_ops/traffic_ops_golang/routes.go
index 13e047040..518776e58 100644
--- a/traffic_ops/traffic_ops_golang/routes.go
+++ b/traffic_ops/traffic_ops_golang/routes.go
@@ -101,9 +101,10 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodGet, `cachegroups/trimmed/?(\.json)?$`,
cachegroup.TrimmedHandler(d.DB.DB), auth.PrivLevelReadOnly, Authenticated, nil},
{1.1, http.MethodGet, `cachegroups/?(\.json)?$`,
api.ReadHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelReadOnly,
Authenticated, nil},
{1.1, http.MethodGet, `cachegroups/{id}$`,
api.ReadHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelReadOnly,
Authenticated, nil},
- {1.1, http.MethodPut, `cachegroups/{id}$`,
api.UpdateHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
- {1.1, http.MethodPost, `cachegroups/?$`,
api.CreateHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
- {1.1, http.MethodDelete, `cachegroups/{id}$`,
api.DeleteHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
+ // these were commented out because all of the rules on the
Perl side were not captured. I.e. deleting a cg should not delete all the
attached servers. Issue #2597.
+ //{1.1, http.MethodPut, `cachegroups/{id}$`,
api.UpdateHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
+ //{1.1, http.MethodPost, `cachegroups/?$`,
api.CreateHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
+ //{1.1, http.MethodDelete, `cachegroups/{id}$`,
api.DeleteHandler(cachegroup.GetTypeSingleton()), auth.PrivLevelOperations,
Authenticated, nil},
{1.1, http.MethodPost, `cachegroups/{id}/queue_update$`,
cachegroup.QueueUpdates(d.DB.DB), auth.PrivLevelOperations, Authenticated, nil},
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
