rob05c commented on a change in pull request #2606: Updates 'grovetccfg' to to
write a grove.cfg from the grove servers profile
URL: https://github.com/apache/trafficcontrol/pull/2606#discussion_r207914731
##########
File path: grove/grovetccfg/grovetccfg.go
##########
@@ -94,13 +99,13 @@ func CopyAndGzipFile(src, dst string) error {
}
// BackupFile copies the given file to a new file in the subdirectory
"/remap_history", with the name suffixed by the current timestamp. Returns nil
if the given file doesn't exist (nothing to back up).
-func BackupFile(path string) error {
+func BackupFile(path string, bkup_dir string) error {
Review comment:
`bkup_dir` should be camel case, and while Go favors brevity `bkup` is a bit
extreme, I'd recommend `backupDir`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
