jrushford commented on issue #2606: Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile URL: https://github.com/apache/trafficcontrol/pull/2606#issuecomment-410781876 Hey Rob, I’ve made the requested changes except for this one, I do not see that there is currently any profile enum in go-tc. If necessary, I could add one I suppose. I had several commits so, I’ve also squashed them. If it helps, on ipcdn-cache-59.cdnlab.comcast.net, I have a cdn-in-a-box running with the current database from staging where I have added the GROVE_PROFILE to profile_type_values and have a EDGE1_XCR_GROVE_0.1-9001 built. I’ve been running this script on cache-59 for testing, you could use my hostname below or pick another and change it’s profile to use this one: #!/bin/bash ./grovetccfg -ignore-update-flag -host cdn-ec-sfb-001-01 -touser jrushford -topass twelve -insecure -tourl https://localhost:6443 -pretty From: Robert Butts <[email protected]> Reply-To: apache/trafficcontrol <[email protected]> Date: Monday, August 6, 2018 at 9:04 AM To: apache/trafficcontrol <[email protected]> Cc: John Rushford <[email protected]>, Author <[email protected]> Subject: [EXTERNAL] Re: [apache/trafficcontrol] Updates 'grovetccfg' to to write a grove.cfg from the grove servers profile (#2606) Ok, I commented on all the formatting things I saw. I didn't do an actual review, because that will take longer, and I'll need to install and run it against a TO instance with the expected profile. I'll try to do that as soon as I can find the time. Feel free to fix the things noted now, or wait until the full review, whatever you prefer. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://github.com/apache/trafficcontrol/pull/2606#issuecomment-410739702>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEVyblOt5KJLSwGGGOEsofkJihPmO-ONks5uOFrogaJpZM4VrE7r>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
