rob05c commented on issue #2711: add profile constraint cdn not null URL: https://github.com/apache/trafficcontrol/pull/2711#issuecomment-413985870 For the record, I don't approve of testing Postgres itself. It's certainly valuable to test the API, for example, verifying that an attempt to insert a profile without a CDN returns a proper 4xx or 5xx with a proper message (assuming those tests aren't too relatively expensive to write). But IMO we shouldn't be writing tests which do nothing but verify that PostgreSQL behaves correctly. The only thing this test verifies, is that PostgreSQL database constraints work correctly. IMO it's not the job of Traffic Control to verify PostgreSQL' behavior, and such tests obfuscate and obstruct the useful tests. But, I'm merging, because the value of this fix far outweighs any undesirability.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
