rob05c commented on issue #2802: TO Go: signatureType required for POST 
deliveryservice
URL: https://github.com/apache/trafficcontrol/issues/2802#issuecomment-421421896
 
 
   Do you mean `signing_algorithm`, which is a `deliveryservice_signature_type` 
type in the database?
   
   It shouldn't be required, and a db error shouldn't occur, the db allows 
nulls there.
   
   It's new in API 1.3, so we can't require it in 1.2. But, we shouldn't be, 
and it should be defaulted here: 
https://github.com/apache/trafficcontrol/blob/master/lib/go-tc/deliveryservices.go#L389
   
   If `Sanitize()` isn't being called correctly on the input of a POST or PUT, 
that's a bug.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to