dangogh commented on a change in pull request #2834: TO Golang: Rewrite /api/*/users endpoints URL: https://github.com/apache/trafficcontrol/pull/2834#discussion_r222766165
########## File path: traffic_ops/app/db/migrations/20180920000626_remove_gid_uid_confirmLocalPasswd.sql ########## @@ -0,0 +1,28 @@ +/* + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +-- +goose Up +-- SQL in section 'Up' is executed when this migration is applied + +-- we are going to clean up capabilities for a reseed +-- it is really just a few, but I'm deleting everything just so I don't miss anything.. +ALTER TABLE tm_user DROP COLUMN gid; +ALTER TABLE tm_user DROP COLUMN uid; +ALTER TABLE tm_user DROP COLUMN confirm_local_passwd; Review comment: removing these columns causes problems in the Perl code since it expects these columns to exist. Best to leave the columns in place, but have the Go code not rely on them. Just delete the migration file... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
