ocket8888 commented on a change in pull request #2907: WIP Using HTML5 Elements
in CDN Snapshot Diffs
URL: https://github.com/apache/trafficcontrol/pull/2907#discussion_r223105793
##########
File path:
traffic_portal/app/src/modules/private/cdns/config/ConfigController.js
##########
@@ -56,33 +56,53 @@ var ConfigController = function(cdn, currentSnapshot,
newSnapshot, $scope, $stat
if (oldJSON) {
var diff = JsDiff.diffJson(oldJSON, newJSON);
diff.forEach(function(part){
- var partChanged = part.added || part.removed;
- if (!partChanged && part.count > (context * 2))
{
- var partArr = part.value.split("\n"),
- newArr = [];
- _.each(partArr, function(element,
index) {
- if (index < context || index >
partArr.length - context) {
- newArr.push(element);
- }
- });
- newArr.splice(context, 0,
"\n*****************\n* TRUNCATED *\n*****************\n");
Review comment:
Yeah, I'll put that back in once it's working. Do you think that could be
why nothing's showing up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
