traeak commented on a change in pull request #2931: reuse single riak cluster 
connection, up riak heartbeat timeout
URL: https://github.com/apache/trafficcontrol/pull/2931#discussion_r229308963
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/urisigning.go
 ##########
 @@ -65,12 +65,11 @@ func getURIsignkeysHandler(w http.ResponseWriter, r 
*http.Request) {
                return
        }
 
-       cluster, err := riaksvc.StartCluster(inf.Tx.Tx, 
inf.Config.RiakAuthOptions)
 
 Review comment:
   The ping is designed to check individual machines in the cluster.  So it has 
to iterate on each machine in the server list, put it into its own cluster, 
then ping it.  Otherwise there's no way to individually determine health 
without going through the error logs directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to