rawlinp commented on a change in pull request #2928: TO Client:  no ids 
required in input json
URL: https://github.com/apache/trafficcontrol/pull/2928#discussion_r230404805
 
 

 ##########
 File path: traffic_ops/testing/api/v14/user_test.go
 ##########
 @@ -95,20 +100,46 @@ func UpdateTestUsers(t *testing.T) {
 func GetTestUsers(t *testing.T) {
        _, _, err := TOSession.GetUsers()
        if err != nil {
-               t.Fatalf("cannot GET users: %v\n", err)
+               t.Errorf("cannot GET users: %v\n", err)
        }
 }
 
 func GetTestUserCurrent(t *testing.T) {
        user, _, err := TOSession.GetUserCurrent()
        if err != nil {
-               t.Fatalf("cannot GET current user: %v\n", err)
+               t.Errorf("cannot GET current user: %v\n", err)
        }
        if user.UserName == nil {
-               t.Fatalf("current user expected: %v actual: %v\n", 
SessionUserName, nil)
+               t.Errorf("current user expected: %v actual: %v\n", 
SessionUserName, nil)
        }
        if *user.UserName != SessionUserName {
-               t.Fatalf("current user expected: %v actual: %v\n", 
SessionUserName, *user.UserName)
+               t.Errorf("current user expected: %v actual: %v\n", 
SessionUserName, *user.UserName)
+       }
+}
+
+// ForceDeleteTestUsers forcibly deletes the users from the db.
+func ForceDeleteTestUsers(t *testing.T) {
 
 Review comment:
   Ok, right on. I was thinking we should make it private so that it's 
unavailable to the other tests, but then I realized that wouldn't do anything 
since all the tests are in the same package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to