ocket8888 commented on a change in pull request #3023: WIP Supported routes fetch URL: https://github.com/apache/trafficcontrol/pull/3023#discussion_r233213542
########## File path: traffic_ops/traffic_ops_golang/traffic_ops_golang.go ########## @@ -46,6 +46,9 @@ import ( // set the version at build time: `go build -X "main.version=..."` var version = "development" +// Traffic Ops version, set before building +const Version = "3.0.0" Review comment: that "version" should not be named "version" imo - it describes the environment, not the actual version. AFAIK there's no previously-existing code that sets an actual version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
