dangogh commented on a change in pull request #3026: Compare error handling
URL: https://github.com/apache/trafficcontrol/pull/3026#discussion_r233891943
##########
File path: traffic_ops/testing/compare/compare.go
##########
@@ -239,46 +257,48 @@ func (to *Connect) get(route string) (string, error) {
if err != nil {
return "", err
}
- req.Header.Set("Content-Type", "application/json")
+ req.Header.Set("Accept", "application/json")
+
+ // Should wait for any retries to complete before sending a request
+ to.mutex.Lock()
Review comment:
rather than unlocking before each return, better to `defer
to.mutex.Unlock()` here..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
