genzgd commented on a change in pull request #2922: Update logging.config
generation to allow additional types and logging filters
URL: https://github.com/apache/trafficcontrol/pull/2922#discussion_r235124464
##########
File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm
##########
@@ -1451,24 +1449,51 @@ sub logging_dot_config {
$text .= " Format = '" . $format . " '\n";
$text .= "}\n";
}
+ }
+
+ for ( my $i = 0; $i < $max_log_objects; $i = $i + 1) {
+ my $log_filter_field = "LogFilter";
+ if ( $i > 0 ) {
+ $log_filter_field = $log_filter_field . "$i";
+ }
+ my $log_filter_name = $data->{$log_filter_field . ".Name"} ||
"";
+ if ( length($log_filter_name) > 0) {
+ my $filter = $data->{$log_filter_field . ".Filter"};
+ $filter =~ s/"/\\\"/g;
Review comment:
The filter is defined in single quotes just like the Format string:
filter.accept('%<{X-ATS-SVC-ID}cqh> CONTAIN logds') is what I've been testing
with. If lua will accept the unescaped double quote for something like
filter.accept(field CONTAIN ") then the escaping is indeed unnecessary (and I
can't imagine the use case for searching for quotes in a value anyway)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
