rawlinp opened a new pull request #3072: Emit warning when adding self-signed certs using the API rather than prohibiting them URL: https://github.com/apache/trafficcontrol/pull/3072 #### What does this PR do? Rather than prohibit adding self-signed certs via the API, emit a warning to indicate that self-signed certs were detected and might not be completely valid. #### Which TC components are affected by this PR? - [ ] Documentation - [ ] Grove - [ ] Traffic Analytics - [ ] Traffic Monitor - [x] Traffic Ops - [ ] Traffic Ops ORT - [x] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] Other _________ #### What is the best way to verify this PR? Run the traffic_ops_golang unit tests. In TP, generate self-signed certs for a DS. In the next view where the certs are shown, add a space to one of the input fields and remove it in order to use the "update keys" button. This will re-add your self-signed certificates using the API. You should see a message in a yellow box at the top that mentions the keys were added successfully but are signed by an unknown authority and might be invalid. #### Check all that apply - [x] This PR includes tests - [ ] This PR includes documentation updates - [ ] This PR includes an update to CHANGELOG.md - [ ] This PR includes all required license headers - [ ] This PR includes a database migration (ensure that migration sequence is correct) - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
