rawlinp commented on a change in pull request #2785: In Traffic Router Support 
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r236466900
 
 

 ##########
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/config/CertificateChecker.java
 ##########
 @@ -42,6 +43,32 @@ public String getDeliveryServiceType(final JsonNode 
deliveryServiceJson) {
                return null;
        }
 
+       public String getDeliveryServiceType(final DeliveryService 
deliveryService) {
 
 Review comment:
   These added methods seem to duplicate the existing ones. Can they be 
consolidated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to