rawlinp commented on a change in pull request #2785: In Traffic Router Support
Snapshots which only update Delivery Services
URL: https://github.com/apache/trafficcontrol/pull/2785#discussion_r238875146
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/SignatureManager.java
##########
@@ -72,7 +72,15 @@ protected void destroy() {
}
}
+ public void refreshKeyMap() {
+ initKeyMap(true);
+ }
+
private void initKeyMap() {
+ initKeyMap(false);
+ }
+
+ private void initKeyMap(final boolean suppressReload) {
Review comment:
Can we rename `suppressReload` to `doReload` and invert the conditions so
they read like this (avoiding double-negative)?
```
if (doReload) {
reload();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
