moltzaum opened a new pull request #3100: Updated profiles and parameters test 
to clean up parameters better
URL: https://github.com/apache/trafficcontrol/pull/3100
 
 
   #### What this PR does
   Updated profile test to delete parameters it generates. Updated parameters 
delete test so that it checks whether or not a parameter was deleted by id 
instead of name and config (If there happens to be a parameter created by a 
profile there is a conflict).
   
   #### How to verify this PR
   Checkout the first commit, build traffic ops, run `go test -run TestP` and 
check the database to make sure no parameters exist. Repeat for the second 
commit. The first commit should show the problem, and the second should fix it.
   
   #### Which TC components are affected by this PR?
   
   This PR adds data to `tc-fixtures.json`, then modifies the tests so that 
they still pass. The data in `tc-fixtures.json` I will need to use.
   
   #### Check all that apply
   
   - [x] This PR includes tests (not new ones)
   - [ ] This PR includes documentation updates
   - [ ] This PR includes an update to CHANGELOG.md
   - [x] This PR includes all required license headers (no new files)
   - [ ] This PR includes a database migration (ensure that migration sequence 
is correct)
   - [ ] This PR fixes a serious security flaw. Read more: 
[www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to