ezelkow1 commented on a change in pull request #3104: Add monitoring.json
snapshotting
URL: https://github.com/apache/trafficcontrol/pull/3104#discussion_r240791194
##########
File path: traffic_ops/traffic_ops_golang/routes.go
##########
@@ -142,7 +141,7 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.4, http.MethodGet, `cdns/dnsseckeys/refresh/?(\.json)?$`,
cdn.RefreshDNSSECKeys, auth.PrivLevelOperations, Authenticated, nil},
//CDN: Monitoring: Traffic Monitor
- {1.1, http.MethodGet,
`cdns/{cdn}/configs/monitoring(\.json)?$`, monitoring.Get,
auth.PrivLevelReadOnly, Authenticated, nil},
+ {1.1, http.MethodGet,
`cdns/{cdn}/configs/monitoring(\.json)?$`,
crconfig.SnapshotGetMonitoringHandler, auth.PrivLevelReadOnly, Authenticated,
nil},
Review comment:
@dneuman64 would you be good with us opening up a separate issue for that?
We were throwing around some ideas like a diff end point instead of a full raw
one and things like that, but its a bit out of the scope of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
