rawlinp opened a new pull request #3143: Fix improper file slurping in Perl URL: https://github.com/apache/trafficcontrol/pull/3143 #### What does this PR do? The proper way to enable slurp mode is by doing `local $/;`. When you do `undef $/` it is undefining the global `$/` input record separator which is bad and can cause a multitude of problems. Using the `local` version only nullifies the input record separator locally in order to enable slurp mode in that particular function rather than changing it globally. #### Which TC components are affected by this PR? - [ ] Documentation - [ ] Grove - [ ] Traffic Analytics - [ ] Traffic Monitor - [x] Traffic Ops - [ ] Traffic Ops ORT - [ ] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] Other _________ #### What is the best way to verify this PR? Hit the `POST /api/$version/isos?stream=yes` endpoint. This can be done in Traffic Portal, just make sure to set stream=yes in order to hit the changed code. I'm not sure how to really verify `parse_retention_period_in_seconds` since I can't find anywhere in the code that actually uses that function. The GenDbDump change isn't really verifiable anymore since it's a UI endpoint, but this should cover our bases in case it is being used in some obscure way by a non-UI endpoint. #### Check all that apply - [ ] This PR includes tests - [ ] This PR includes documentation updates - [ ] This PR includes an update to CHANGELOG.md - [ ] This PR includes all required license headers - [ ] This PR includes a database migration (ensure that migration sequence is correct) - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
