rob05c opened a new pull request #3163: Fix Traffic Ops Tenancy and Activity Bugs, Fix TO API Test Framework to work with Tenancy URL: https://github.com/apache/trafficcontrol/pull/3163 This fixes major TO Tenancy bugs, as well as fixing the TO API framework to work with Tenancy enabled, and enabling it. Unfortunately, all the tenancy issues, and the test framework, are intimately related, and there isn't a good way to separate them; so this PR is unfortunately large. Specifically: - Fix TO Tenancy checks to consider whether the user's tenant is active, not whether the resource's tenant is active. - Fix TO Tenancy to prevent access when parent tenants (of the user's tenant) are inactive. - Add TO API Tests to verify tenancy, verify access is disabled when parents or self are inactive. - Fix TO API Test user panic on test failure. - Fix TO API Test tenants to automatically delete children before parents, rather than hard-coding. - Fix TO API Test parameters race condition, fixed to delete all parameters not only first name+file. - Fix TO API Tests to enable Tenancy on all tests (by creating Parameters, which creates the use_tenancy param). The TO API Tests were completely broken with tenancy, due to the above bugs. With the bugs fixed, the tests pass with tenancy enabled. Fixes #2732 #### What does this PR do? Fixes #2732 #### Which TC components are affected by this PR? - [ ] Documentation - [ ] Grove - [ ] Traffic Analytics - [ ] Traffic Monitor - [x] Traffic Ops - [ ] Traffic Ops ORT - [ ] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] Other _________ #### What is the best way to verify this PR? Run API tests. Run TO with Tenancy enabled, verify resources are accessible as expected. #### Check all that apply - [x] This PR includes tests - [ ] This PR includes documentation updates - [ ] This PR includes an update to CHANGELOG.md - [ ] This PR includes all required license headers - [ ] This PR includes a database migration (ensure that migration sequence is correct) - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/) <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
