dangogh commented on a change in pull request #3163: Fix Traffic Ops Tenancy
and Activity Bugs, Fix TO API Test Framework to work with Tenancy
URL: https://github.com/apache/trafficcontrol/pull/3163#discussion_r244386709
##########
File path: traffic_ops/testing/api/v14/user_test.go
##########
@@ -61,11 +63,10 @@ func CreateTestUsers(t *testing.T) {
for _, user := range testData.Users {
resp, _, err := TOSession.CreateUser(&user)
- log.Debugln("Response: ", resp.Alerts)
-
if err != nil {
- t.Errorf("could not CREATE user: %v\n", err)
+ t.Fatalf("could not CREATE user: %v\n", err)
Review comment:
+1 -- if the Fatalf occurs before the test gets cleaned up, the following
test may fail. Really should only use Fatalf if we can't recover from the
situation, and that should be made very clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
