ocket8888 commented on a change in pull request #3177: Added warning SQL query 
for duplicated origins
URL: https://github.com/apache/trafficcontrol/pull/3177#discussion_r245365736
 
 

 ##########
 File path: traffic_ops/app/db/admin.pl
 ##########
 @@ -64,7 +64,7 @@
        . "dropdb  - Execute db 'dropdb' on the database for the current 
environment.\n"
 
 Review comment:
   The only reason is stubbornness. People will continue to use the Perl script 
until it's actually removed, totally ignoring the deprecation warning. They 
still need to be served a deprecation notice for their database state or 
they'll be taken by surprise when a non-backwards-compatible upgrade fails.
   I didn't think of just calling the binary, though - that's a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to