ocket8888 commented on a change in pull request #3192: Fix trafficops python client installation URL: https://github.com/apache/trafficcontrol/pull/3192#discussion_r245828867
########## File path: traffic_control/clients/python/trafficops/__init__.py ########## @@ -14,6 +14,8 @@ # limitations under the License. # +from .__version__ import __version__ + # Import Local Modules into the 'trafficops' package namespace for convenience. from .tosession import TOSession from .restapi import InvalidJSONError, LoginError, OperationError, api_request, RestApiSession Review comment: to be clear, by "these bits" I mean the local module imports (and consequently the `__all__` definition). Failing that, the package-level `__version__` should still be defined to be the package's version. Otherwise to get the version from within Python you'd need to do `from trafficops.__version__ import __version__` instead of just `from trafficops import __version__` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
