rawlinp commented on a change in pull request #3192: Fix trafficops python client installation URL: https://github.com/apache/trafficcontrol/pull/3192#discussion_r245841634
########## File path: traffic_control/clients/python/trafficops/__init__.py ########## @@ -14,6 +14,8 @@ # limitations under the License. # +from .__version__ import __version__ + # Import Local Modules into the 'trafficops' package namespace for convenience. from .tosession import TOSession from .restapi import InvalidJSONError, LoginError, OperationError, api_request, RestApiSession Review comment: I'm not totally following the advantages you're proposing. I can get the module version the same way as it was before: ``` Python 3.6.7 (default, Jan 4 2019, 09:57:41) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import trafficops >>> trafficops.__version__ '1.0.0' >>> ``` as well as: ``` Python 3.6.7 (default, Jan 4 2019, 09:57:41) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> from trafficops import __version__ >>> __version__ '1.0.0' >>> ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
