ezelkow1 commented on a change in pull request #3279: Records.config ds profile
parameters
URL: https://github.com/apache/trafficcontrol/pull/3279#discussion_r252402650
##########
File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm
##########
@@ -2769,6 +2790,27 @@ sub build_remap_line {
}
}
+ #Add DS profile records.config entries as overrided ATS parameters
+ if ( defined( $remap->{'param'}->{'records.config'} ) ) {
Review comment:
Between the build_remap and the mid_remap there is a lot of similar
duplication. It might make sense to make it a sub but it also follows the
existing code convention thats there to just leave it as is
We may also want to treat edge/mid differently in the future depending on
how this gets used (though will probably completely change if/when DS profiles
get removed or all the ATS config gets moved in to golang) if we want a way to
differentiate parameters that may only apply to one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
