ocket8888 commented on a change in pull request #3281: CIAB: Fixed the method 
of obtaining IP
URL: https://github.com/apache/trafficcontrol/pull/3281#discussion_r252473573
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/docker-compose.yml
 ##########
 @@ -87,6 +89,7 @@ services:
     depends_on:
       - db
       - enroller
+      - trafficvault
 
 Review comment:
   adding TV as a dependency of TO guarantees that it will be _started_ before 
TO, but that doesn't guarantee it will be _done_ starting by the time TO needs 
it. "starting" the container is an instantaneous action that spins off the 
container's `CMD` as an asynchronous procedure. Ordering within that cannot be 
guaranteed. I think your idea about using the enroller could work, if I 
understand you right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to