rawlinp commented on a change in pull request #2979: Fix TO Go DSS GET
endpoints to check tenancy
URL: https://github.com/apache/trafficcontrol/pull/2979#discussion_r254375825
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
##########
@@ -142,7 +143,21 @@ func (dss *TODeliveryServiceServer) readDSS(tx *sqlx.Tx,
user *auth.CurrentUser,
orderby = "deliveryService"
}
- query, err := selectQuery(orderby, strconv.Itoa(limit),
strconv.Itoa(offset))
+ tenancyEnabled, err := tenant.IsTenancyEnabledTx(tx.Tx)
Review comment:
> But until the `use_tenancy` parameter can actually be removed so that
tenancy is a hard requirement of ATC it just seems safer to keep checking.
Then we should do our best to remove all the usages of the `use_tenancy`
parameter from the codebase. I think the usage is fairly self-contained within
helper functions, so maybe we can just change the helper functions to just
return `true`. Then we can remove all the usages of the now-useless helper
functions to clean up the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
