ocket8888 commented on a change in pull request #3605: Fix TM polling urls with
ports
URL: https://github.com/apache/trafficcontrol/pull/3605#discussion_r288655212
##########
File path: lib/go-tc/traffic_router.go
##########
@@ -136,6 +136,7 @@ type TrafficServer struct {
CacheGroup string `json:"cacheGroup"`
IP6 string `json:"ip6"`
Port int `json:"port"`
+ HTTPSPort int `json:"httpsPort,omitempty"`
Review comment:
This is the subject of some debate, so I'd appreciate other people chiming
in, but personally I feel that fields that are `NULL` should marshal as `null`
and not `undefined` - it keeps the structure more deterministic and easier to
deal with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
