ocket8888 commented on a change in pull request #3680: TP: adds the ability to
rearrange table columns as well as toggle column visibility/searchability
URL: https://github.com/apache/trafficcontrol/pull/3680#discussion_r295836643
##########
File path:
traffic_portal/app/src/common/modules/table/types/table.types.tpl.html
##########
@@ -25,6 +25,19 @@
<div class="pull-right">
<button class="btn btn-primary" title="Create Type"
ng-click="createType()"><i class="fa fa-plus"></i></button>
<button class="btn btn-default" title="Refresh"
ng-click="refresh()"><i class="fa fa-refresh"></i></button>
+ <div class="btn-group" role="group" title="Select Table Columns"
uib-dropdown is-open="columnSettings.isopen">
+ <button type="button" class="btn btn-default dropdown-toggle"
uib-dropdown-toggle aria-haspopup="true" aria-expanded="false">
+ <i class="fa fa-columns"></i>
+ <span class="caret"></span>
+ </button>
+ <menu ng-click="$event.stopPropagation()"
class="column-settings dropdown-menu-right dropdown-menu" uib-dropdown-menu>
+ <menuitem ng-repeat="c in columns">
Review comment:
So, I think maybe I should've headed this off. `<menuitem>` has been
deprecated, so these should still be `li[role="menuitem"]`. Basically,
`<menuitem>` was meant for right-click "context menu"s - but only Firefox ever
supported that afaik - , whereas `menu[^type]` and `menu[type="toolbar"]`s
should contain list items, flow content, templates and scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
