ocket8888 commented on a change in pull request #3742: Restricted job creation
to Portal and above
URL: https://github.com/apache/trafficcontrol/pull/3742#discussion_r307394627
##########
File path: traffic_ops/app/lib/API/Job.pm
##########
@@ -181,7 +185,7 @@ sub create_current_user_job {
return $self->forbidden("Forbidden. Delivery-service
tenant is not available to the user.");
}
} else {
- if ( !&is_oper($self) &&
!$self->is_delivery_service_assigned($ds_id) ) {
+ if ( !&is_portal($self) &&
!$self->is_delivery_service_assigned($ds_id) ) {
Review comment:
I can't do that, since it would change the API behavior beyond the scope of
this security fix. I shouldn't be checking for Role twice, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
