mitchell852 commented on a change in pull request #3742: Restricted job
creation to Portal and above
URL: https://github.com/apache/trafficcontrol/pull/3742#discussion_r307823782
##########
File path: traffic_ops/app/lib/API/Job.pm
##########
@@ -181,7 +185,7 @@ sub create_current_user_job {
return $self->forbidden("Forbidden. Delivery-service
tenant is not available to the user.");
}
} else {
- if ( !&is_oper($self) &&
!$self->is_delivery_service_assigned($ds_id) ) {
+ if ( !&is_portal($self) &&
!$self->is_delivery_service_assigned($ds_id) ) {
Review comment:
i thought there was some work done to completely remove the ability to turn
off tenancy but i guess there were many pieces that were missed. so imo i'd
take this opportunity to remove that `$tenant_utils->use_tenancy()` but if you
want to leave it, that's fine too. i'll create a tech debt ticket to clean that
stuff up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
