mitchell852 commented on a change in pull request #3758: Rewrote
deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r307918581
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -104,6 +105,9 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodPost, `asns/?$`,
api.CreateHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
{1.1, http.MethodDelete, `asns/{id}$`,
api.DeleteHandler(&asn.TOASNV11{}), auth.PrivLevelOperations, Authenticated,
nil},
+ // Traffic Stats access
+ {1.2, http.MethodGet, `deliveryservice_stats`,
trafficstats.GetDSStats, auth.PrivLevelOperations, Authenticated, nil},
Review comment:
so basically the way it is implemented now it is asking "is this ds assigned
to you" and if so, you are good to go. but that behavior should have been
changed a long time ago to use tenancy instead.
in which case NO role was checked but i think R/O makes perfect sense here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
