ocket8888 commented on a change in pull request #3739: TP: adds the ability to
rearrange delivery service table columns as well as toggle column
visibility/searchability
URL: https://github.com/apache/trafficcontrol/pull/3739#discussion_r308299296
##########
File path:
traffic_portal/test/end_to_end/DeliveryServices/delivery-services-spec.js
##########
@@ -99,6 +99,25 @@ describe('Traffic Portal Delivery Services Suite',
function() {
expect(browser.getCurrentUrl().then(commonFunctions.urlPath)).toEqual(commonFunctions.urlPath(browser.baseUrl)+"#!/delivery-services");
});
+ it('should toggle the visibility of the first table column ',
function() {
+ browser.driver.findElement(by.id('toggleColumns')).click();
+ let first = element.all(by.css('input[type=checkbox]')).first();
+ expect(first.isSelected()).toBe(true);
+ browser.sleep(2000);
+
+ first.click();
+ browser.sleep(2000);
+
+ expect(first.isSelected()).toBe(false);
+
+ browser.sleep(5000);
Review comment:
What's with all these sleeps? This test is going to take a minimum of 9
seconds to run
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
