rawlinp commented on a change in pull request #3593: Add TO Go profile ATS
configs
URL: https://github.com/apache/trafficcontrol/pull/3593#discussion_r308501887
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -381,6 +382,23 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodGet,
`cdns/{cdn-name-or-id}/configfiles/ats/regex_revalidate.config/?(\.json)?$`,
ats.GetRegexRevalidateDotConfig, auth.PrivLevelOperations, Authenticated, nil},
{1.1, http.MethodGet,
`cdns/{cdn-name-or-id}/configfiles/ats/hdr_rw_mid_{xml-id}.config/?(\.json)?$`,
ats.GetMidHeaderRewriteDotConfig, auth.PrivLevelOperations, Authenticated, nil},
{1.1, http.MethodGet,
`cdns/{cdn-name-or-id}/configfiles/ats/hdr_rw_{xml-id}.config/?(\.json)?$`,
ats.GetEdgeHeaderRewriteDotConfig, auth.PrivLevelOperations, Authenticated,
nil},
+ {1.1, http.MethodGet,
`cdns/{cdn-name-or-id}/configfiles/ats/hdr_rw_{xml-id}.config/?(\.json)?$`,
ats.GetEdgeHeaderRewriteDotConfig, auth.PrivLevelOperations, Authenticated,
nil},
+
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/12M_facts/?$`,
atsprofile.GetFacts, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/50-ats.rules/?$`,
atsprofile.GetATSDotRules, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/astats.config/?$`,
atsprofile.GetAstats, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/cache.config/?$`,
atsprofile.GetCache, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/drop_qstring.config/?$`,
atsprofile.GetDropQString, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/logging.config/?$`,
atsprofile.GetLogging, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/logs_xml.config/?$`,
atsprofile.GetLogsXML, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/plugin.config/?$`,
atsprofile.GetPlugin, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/records.config/?$`,
atsprofile.GetRecords, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/storage.config/?$`,
atsprofile.GetStorage, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/sysctl.conf/?$`,
atsprofile.GetSysctl, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/url_sig_{file}.config/?$`,
atsprofile.GetURLSig, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/uri_signing_{file}.config/?$`,
atsprofile.GetURISigning, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/volume.config/?$`,
atsprofile.GetVolume, auth.PrivLevelOperations, Authenticated, nil},
+ {1.1, http.MethodGet,
`profiles/{profile-name-or-id}/configfiles/ats/{file}/?$`,
atsprofile.GetUnknown, auth.PrivLevelOperations, Authenticated, nil},
Review comment:
This this set of profile config routes is supposed to be exhaustive, it
appears that `logging.yaml` is missing, and I think it would get picked up by
this `GetUnknown` handler which might lead to badness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
