rawlinp commented on a change in pull request #3772: CIAB: add sanity checks around x509 file existence URL: https://github.com/apache/trafficcontrol/pull/3772#discussion_r310674634
########## File path: infrastructure/cdn-in-a-box/traffic_ops/run-go.sh ########## @@ -87,6 +87,12 @@ while true; do done ### Add SSL keys for demo1 delivery service +until [[ -s "$X509_DEMO1_CERT_FILE" && -s "$X509_DEMO1_REQUEST_FILE" && -s "$X509_DEMO1_KEY_FILE" ]] +do + echo "Waiting on X509_DEMO1 files to exist" + sleep 3 Review comment: Yeah, the general async architecture of CIAB tends to require waiting on things indefinitely. That can be frustrating sometimes though, because it's not always clear how long CIAB is "supposed to take" in order to fully startup, and it's not immediately obvious when CIAB has actually started up properly from the logs. That said, this PR jives w/ the existing architecture, and if we to change the architecture, we should discuss/design that in a more open forum. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
