rob05c opened a new pull request #3899: Add TO Go server cache configs
   Adds Traffic Ops Golang /servers ATS config routes.
   I've parity tested against all our production servers, they all diff 
identical, except irrelevant ordering, and in some cases the ip_allow 
   As far as I can tell, the IP allow coalescing in Go is behaving like it 
should, but Perl sometimes doesn't seem to coalesce and combine like the 
parameters suggest. Specifically, sometimes Perl seems to combine fewer IPs 
than the combine parameter passed. Whoever reviews this can verify if they 
think it's correct.
   Includes unit tests, includes changelog update. No documentation, no 
interface change.
   - [x] This PR is not related to any other Issue
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   ## What is the best way to verify this PR?
   Generate configs, compare with Perl. This can be done with either an older 
TO, or personally, I change routes.go to serve Go at 1.4, causing /api/1.1 to 
return Perl for comparing.
   ## If this is a bug fix, what versions of Traffic Control are affected?
   Not a bug fix.
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation 
is unnecessary
   - [x] This PR includes an update to OR such an update is not 
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR 
does not include a database migration
Apache Software Foundation's security 
guidelines]( for details)

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to