ocket8888 commented on a change in pull request #3900: Rewrite 
/cachegroups/{{id}}/parameters to Go
URL: https://github.com/apache/trafficcontrol/pull/3900#discussion_r320845597

 File path: traffic_ops/traffic_ops_golang/cachegroup/parameters.go
 @@ -0,0 +1,97 @@
+package cachegroup
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import (
+       "errors"
+       "net/http"
+       "github.com/apache/trafficcontrol/lib/go-tc"
+       "github.com/apache/trafficcontrol/lib/go-util"
+       "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
+       "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+const (
+       CacheGroupIDQueryParam = "id"
+       ParameterIDQueryParam  = "parameterId"
+//we need a type alias to define functions on
+type TOCacheGroupParameter struct {
+       api.APIInfoImpl `json:"-"`
+       tc.ParameterNullable
 Review comment:
   Using this inserts a new field into the response that didn't exist in the 
Perl implementation: `profiles`. That's fine for a v1.4 route, but to be a 
generic rewrite of 1.x it shouldn't add things. It also omits sub-second 
precision to the `lastUpdated` timestamp, which is likely less of a problem, 
since compliant parsers (probably?) shouldn't care. Might be nice, though.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to