ocket8888 commented on a change in pull request #3691: Some best-practices updates to the kickstart script URL: https://github.com/apache/trafficcontrol/pull/3691#discussion_r320913400
########## File path: misc/kickstart_create_network_line.py ########## @@ -231,43 +238,46 @@ def useable_interfaces(net_devs, nc, iface_speed): dev_list = bondable_iface dev_str = dev_list.pop() for d in dev_list: - dev_str="%(dev_str)s,%(d)s" %vars() + dev_str=",".join([dev_str, d]) else: dev_str = bondable_iface[0] if ('y' in nc['NETWORKING_IPV6'].lower()) and re.search(":",nc['IPV6ADDR']): - temp_var = nc['IPV6ADDR'] - IPV6 = "--ipv6=%(temp_var)s" %vars() + IPV6 = "".join(["--ipv6=", nc["IPV6ADDR"]]) else: if 'y' in nc['NETWORKING_IPV6'].lower(): - if iface_problems is False: + if iface_problems is False: iface_problems = "IPv6 enabled but no address provided" - else: + else: iface_problems = "{0} and IPv6 enabled but no address provided".format(iface_problems) if re.search(":",nc['IPV6ADDR']): if iface_problems is False: iface_problems = "IPv6 is disabled, but IPV6ADDR was set to {0}".format(nc['IPV6ADDR']) else: - iface_problems = "{0} and IPv6 is disabled, but IPV6ADDR was set to {1}".format(iface_problems,nc['IPV6ADDR']) + iface_problems = " ".join([iface_problems, "and IPv6 is disabled, but IPV6ADDR was set to", nc['IPV6ADDR']]) Review comment: This again just came down to string concatenation - I wanted to be consistent. What about, instead of the original line, this was made to use `+` as above? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services