ocket8888 commented on a change in pull request #3919: TP: adds a better view
for comparing/managing params of 2 profiles
URL: https://github.com/apache/trafficcontrol/pull/3919#discussion_r324358651
##########
File path: traffic_portal/app/src/styles/main.scss
##########
@@ -183,6 +183,13 @@ table {
margin-right: 5px;
}
+input[type="checkbox"].dirty {
+ -moz-box-shadow: inset 0 0 10px red;
+ -webkit-box-shadow: inset 0 0 10px red;
+ box-shadow: inset 0 0 10px red;
Review comment:
Red to me means "invalid"/"wrong" - I think a light blue glow would be
better. You could set the "dirty" class on the entire row to make it glow blue,
if you're concerned about a clash with host OS theming colors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
