rob05c edited a comment on issue #2305: Add TO Go cdns/health and
cdns/{name}/health
URL: https://github.com/apache/trafficcontrol/pull/2305#issuecomment-531830110
>also should we be adding tests?
This endpoint calls out to Traffic Monitor. The "API Test" framework doesn't
currently support Monitors. It's also not really possible to unit test; we
could mock everything, but it wouldn't be testing much of anything at that
point (which is why we've been doing "API Tests" for TO).
We should definitely test this (and other Monitor endpoints) when the API
Tests support it. But it'll be a nontrivial amount of work to add that support.
I just made https://github.com/apache/trafficcontrol/issues/3924 - we had
one for Riak, but not Monitors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
