mhoppa commented on a change in pull request #3929: Rewrote
/user/reset_password to Go
URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r326865078
##########
File path: traffic_ops/traffic_ops_golang/login/login.go
##########
@@ -21,26 +21,83 @@ package login
import (
"bytes"
+ "database/sql"
"encoding/json"
"errors"
"fmt"
- "github.com/dgrijalva/jwt-go"
- "github.com/lestrrat-go/jwx/jwk"
+ "html/template"
"net/http"
"net/url"
"path/filepath"
"time"
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/lib/go-tc"
+ "github.com/apache/trafficcontrol/lib/go-rfc"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tocookie"
+ "github.com/dgrijalva/jwt-go"
+ "github.com/google/uuid"
"github.com/jmoiron/sqlx"
+ "github.com/lestrrat-go/jwx/jwk"
)
+type emailFormatter struct {
+ From rfc.EmailAddress
+ To rfc.EmailAddress
+ InstanceName string
+ ResetURL rfc.URL
+ Token string
+}
+
+const instanceNameQuery = `
+SELECT value
+FROM parameter
+WHERE name='tm.instance_name' AND
+ config_file='global'
+`
+const userQueryByEmail = `SELECT COUNT(*)::int::bool FROM tm_user WHERE
email=$1`
+const setTokenQuery = `UPDATE tm_user SET token=$1 WHERE email=$2`
+var resetPasswordEmailTemplate = template.Must(template.New("Password Reset
Email").Parse("From: {{.From}}\r"+`
+To: {{.To}}`+"\r"+`
Review comment:
I wonder if we could make a common email layout template that we can
leverage in all our emails.
Since there are multiple places that will need to send emails we could have
a email layout template that has the From/TO/Subject, HTML set up and then the
users of it can just worry about setting From/TO/Subject values as well as the
body and style (unless this is common across all emails as well)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
