ocket8888 commented on a change in pull request #3929: Rewrote
/user/reset_password to Go
URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r326939956
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/config.sh
##########
@@ -122,7 +122,13 @@ cat <<-EOF >/opt/traffic_ops/app/conf/cdn.conf
"geniso" : {
"iso_root_path" : "/opt/traffic_ops/app/public"
},
- "inactivity_timeout" : 60
+ "inactivity_timeout" : 60,
+ "SMTP" : {
+ "Enabled" : false,
Review comment:
I've seen that in places, but is it convention? I just assumed that it was
done because the JSON parser in Perl doesn't care about the case, and Perl's
variable naming convention (or at least the one we used in Perl) was
`snake_case`. This just matches the naming conventions of Go, allowing the
structures to unmarshal "naturally" without struct tags.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
