rob05c commented on a change in pull request #3929: Rewrote
/user/reset_password to Go
URL: https://github.com/apache/trafficcontrol/pull/3929#discussion_r327234104
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/config.sh
##########
@@ -122,7 +122,13 @@ cat <<-EOF >/opt/traffic_ops/app/conf/cdn.conf
"geniso" : {
"iso_root_path" : "/opt/traffic_ops/app/public"
},
- "inactivity_timeout" : 60
+ "inactivity_timeout" : 60,
+ "SMTP" : {
+ "Enabled" : false,
Review comment:
I think snake_case usually means all lower, including abbreviations.
The Go JSON unmarshaller actually falls back to a case-insensitive match, so
`SMTP` and `"smtp"` actually work. But it doesn't collapse underscores, so
`InactiveTimeout` and `"inactive_timeout"` would fail:
https://play.golang.org/p/4ZJh1bN81JA
Which is why I prefer always using struct tags - because the tagless
behavior isn't always obvious to readers who haven't memorized the spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
