ocket8888 commented on a change in pull request #3935: Rewrite POST servercheck
to GO
URL: https://github.com/apache/trafficcontrol/pull/3935#discussion_r327813484
##########
File path: lib/go-tc/serverchecks.go
##########
@@ -108,37 +107,53 @@ type Servercheck struct {
}
// A Single Servercheck struct for Update and Create to depict what changed
-// swagger:model ServercheckPost
type ServercheckPost struct {
// The Servercheck data to submit
//
// Name of the server check type
//
// required: true
- Name string `json:"servercheck_short_name" db:"servercheck_short_name"`
+ Name string `json:"servercheck_short_name"`
// ID of the server
//
- // required: true
- ID int `json:"id" db:"id"`
+ ID int `json:"id"`
// Name of the server
- HostName string `json:"name" db:"name"`
Review comment:
don't you need these db struct tags for it to work properly with sqlx?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
