mitchell852 commented on a change in pull request #3933: TP: adds a CSV link to
all tables to enable export of table data to CSV
URL: https://github.com/apache/trafficcontrol/pull/3933#discussion_r328330013
##########
File path:
traffic_portal/app/src/common/modules/table/profilesParamsCompare/table.profilesParamsCompare.tpl.html
##########
@@ -48,8 +48,8 @@
<td data-search="^{{::pp.name}}$">{{::pp.name}}</td>
<td
data-search="^{{::pp.configFile}}$">{{::pp.configFile}}</td>
<td data-search="^{{::pp.value}}$">{{::pp.value}}</td>
- <td class="center" data-order="{{pp.selected1}}"><input
type="checkbox" ng-change="onChange(1)" ng-class="{'dirty': isCheckboxDirty(pp,
1)}" ng-model="pp.selected1"></td>
- <td class="center" data-order="{{pp.selected2}}"><input
type="checkbox" ng-change="onChange(2)" ng-class="{'dirty': isCheckboxDirty(pp,
2)}" ng-model="pp.selected2"></td>
+ <td class="center" data-order="{{pp.selected1}}"><input
type="checkbox" ng-change="onChange(1)" ng-class="{'dirty': isCheckboxDirty(pp,
1)}" ng-model="pp.selected1"><span hidden>{{pp.selected1}}</span></td>
+ <td class="center" data-order="{{pp.selected2}}"><input
type="checkbox" ng-change="onChange(2)" ng-class="{'dirty': isCheckboxDirty(pp,
2)}" ng-model="pp.selected2"><span hidden>{{pp.selected2}}</span></td>
Review comment:
it's because when the table is exported to csv, there is no value in this
table cell. the export is not smart enough to figure out the value of the
checkbox. instead, if i include this hidden field it is hidden from the UI but
gets captured in the export.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
