mitchell852 commented on a change in pull request #3933: TP: adds a CSV link to
all tables to enable export of table data to CSV
URL: https://github.com/apache/trafficcontrol/pull/3933#discussion_r328785535
##########
File path:
traffic_portal/app/src/common/service/application/ApplicationService.js
##########
@@ -38,6 +38,10 @@ var ApplicationService = function($rootScope,
$anchorScroll, $http, messageModel
// jquery DataTables default overrides
$.extend(true, $.fn.dataTable.defaults, {
+ "dom": "lfBrtip",
+ "buttons": [
+ { "extend": "csv", "className": "btn-link", "titleAttr":
"Export to CSV" }
+ ],
Review comment:
i did try an icon and it looked kinda weird just hanging out on the top of
the table. But yes, "Export as CSV" would be better. clarity is good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services