rob05c commented on a change in pull request #3758: Rewrote
deliveryservice_stats to Go
URL: https://github.com/apache/trafficcontrol/pull/3758#discussion_r328791847
##########
File path: traffic_ops/traffic_ops_golang/api/api.go
##########
@@ -369,6 +382,78 @@ func (inf *APIInfo) Close() {
}
}
+// CreateInfluxClient onstructs and returns an InfluxDB HTTP client, if
enabled and when possible.
+// The error this returns should not be exposed to the user; it's for logging
purposes only.
+//
+// If Influx connections are not enabled, this will return `nil` - but also no
error. It is expected
+// that the caller will handle this situation appropriately.
+func (inf *APIInfo) CreateInfluxClient() (c *influx.Client, e error) {
Review comment:
I don't know that we have an official stance as a project, but I think the
majority of the Go community discourages named returns. It makes it non-obvious
what's being returned where. You could set `e` anywhere, and `return` anywhere
else, and then it's hard for a reader to follow that and figure out what `e`
and `c` are being returned at any given `return`.
I won't -1, if you feel strongly about it, but I do think it hinders
readability, and it's better to avoid, so future readers can easily see exactly
what's being returned at every point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
