ocket8888 commented on a change in pull request #3903: Rewrote /user/logout to Go URL: https://github.com/apache/trafficcontrol/pull/3903#discussion_r329177416
########## File path: traffic_ops/traffic_ops_golang/login/logout_test.go ########## @@ -0,0 +1,159 @@ +package login + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import "context" +import "net/http" +import "net/http/httptest" +import "testing" +import "time" + +// import "github.com/apache/trafficcontrol/lib/go-log" Review comment: I don't like setting precedents for arbitrary stylistic changes without a style guide. As a Python programmer this style is most pleasing to me. I'm not saying I'd refuse to put them in blocks, just explaining my choice. If and when (hopefully when) there _is_ a style guide, I'll be more than happy to conform to it. That comment should absolutely be removed, though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
