rob05c commented on issue #3940: Fix typo in GetProfileDS query used to generate cache.config URL: https://github.com/apache/trafficcontrol/pull/3940#issuecomment-536631820 @mhoppa I thought it did cause the API tests to fail, but I was mistaken. I added tests: https://github.com/apache/trafficcontrol/pull/3941 They only test the 200, which catches this issue. They don't extensively test that the config is correct; but, we're moving to cache-side generation and these endpoints won't be used anymore, so it isn't worth adding lots of logic tests. The right place for more of those is the lib/go-atscfg unit tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
