mhoppa commented on a change in pull request #3925: Added SMTP configuration 
and APIInfo Email method
URL: https://github.com/apache/trafficcontrol/pull/3925#discussion_r330171306
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/config/config.go
 ##########
 @@ -100,6 +103,22 @@ type ConfigTrafficOpsGolang struct {
        CRConfigEmulateOldPath bool `json:"crconfig_emulate_old_path"`
 }
 
+// ConfigTO contains information to identify Traffic Ops in a network sense.
+type ConfigTO struct {
+       BaseURL               rfc.URL          `json:"base_url"`
 
 Review comment:
   Should we be using consistent types for our URL representations? in Config 
we use *url.URL for URL. Unsure of the difference 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to