rob05c commented on a change in pull request #3688: Add TO Go remap.config URL: https://github.com/apache/trafficcontrol/pull/3688#discussion_r330303065
########## File path: traffic_ops/ort/atstccfg/remapdotconfig.go ########## @@ -0,0 +1,372 @@ +package main + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import ( + "errors" + "sort" + "strconv" + "strings" + + "github.com/apache/trafficcontrol/lib/go-atscfg" + "github.com/apache/trafficcontrol/lib/go-log" + "github.com/apache/trafficcontrol/lib/go-tc" + "github.com/apache/trafficcontrol/lib/go-util" +) + +func GetConfigFileServerRemapDotConfig(cfg TCCfg, serverNameOrID string) (string, error) { + // TODO TOAPI add /servers?cdn=1 query param + servers, err := GetServers(cfg) + if err != nil { + return "", errors.New("getting servers: " + err.Error()) + } + + server := tc.Server{ID: atscfg.InvalidID} + if serverID, err := strconv.Atoi(serverNameOrID); err == nil { + for _, toServer := range servers { + if toServer.ID == serverID { + server = toServer + break + } + } + } else { + serverName := serverNameOrID + for _, toServer := range servers { + if toServer.HostName == serverName { + server = toServer + break + } + } + } + if server.ID == atscfg.InvalidID { + return "", errors.New("server '" + serverNameOrID + " not found in servers") + } + + serverName := server.HostName + + cdn, err := GetCDN(cfg, tc.CDNName(server.CDNName)) + if err != nil { + return "", errors.New("getting cdn '" + string(server.CDNName) + "': " + err.Error()) + } + + serverCDNDomain := cdn.DomainName + + toToolName, toURL, err := GetTOToolNameAndURLFromTO(cfg) + if err != nil { + return "", errors.New("getting global parameters: " + err.Error()) + } + + serverProfileParameters, err := GetServerProfileParameters(cfg, server.Profile) + if err != nil { + return "", errors.New("getting server profile '" + server.Profile + "' parameters: " + err.Error()) + } + + atsVersionParam := "" + for _, param := range serverProfileParameters { + if param.ConfigFile != "package" || param.Name != "trafficserver" { + continue + } + atsVersionParam = param.Value + break + } + if atsVersionParam == "" { + atsVersionParam = atscfg.DefaultATSVersion + } + + atsMajorVer, err := atscfg.GetATSMajorVersionFromATSVersion(atsVersionParam) + if err != nil { + return "", errors.New("getting ATS major version from version parameter (profile '" + server.Profile + "' configFile 'package' name 'trafficserver'): " + err.Error()) + } + + deliveryServices, err := GetCDNDeliveryServices(cfg, server.CDNID) + if err != nil { + return "", errors.New("getting delivery services: " + err.Error()) + } + + dsIDs := []int{} + for _, ds := range deliveryServices { + if ds.ID == nil { + // TODO log error? + continue + } + dsIDs = append(dsIDs, *ds.ID) + } + + isMid := strings.HasPrefix(server.Type, string(tc.CacheTypeMid)) + + serverIDs := ([]int)(nil) + if !isMid { + // mids use all servers, so pass nil=all. Edges only use this current server + serverIDs = append(serverIDs, server.ID) + } + + dsServers, err := GetDeliveryServiceServers(cfg, dsIDs, serverIDs) + if err != nil { + return "", errors.New("getting parent.config cachegroup parent server delivery service servers: " + err.Error()) + } + + dssMap := map[int]map[int]struct{}{} // set of map[dsID][serverID] + for _, dss := range dsServers { + if dss.Server == nil || dss.DeliveryService == nil { + continue // TODO log? + } + if dssMap[*dss.DeliveryService] == nil { + dssMap[*dss.DeliveryService] = map[int]struct{}{} + } + dssMap[*dss.DeliveryService][*dss.Server] = struct{}{} + } + + useInactive := false + if !isMid { + // mids get inactive DSes, edges don't. This is how it's always behaved, not necessarily how it should. + useInactive = true + } + + filteredDSes := []tc.DeliveryServiceNullable{} + for _, ds := range deliveryServices { + if ds.ID == nil { + continue // TODO log? + } + if ds.Active == nil { + continue // TODO log? + } + if _, ok := dssMap[*ds.ID]; !ok { + continue + } + if !useInactive && !*ds.Active { + continue + } + filteredDSes = append(filteredDSes, ds) + } + + dsRegexes, err := GetDeliveryServiceRegexes(cfg) + if err != nil { + return "", errors.New("getting delivery service regexes: " + err.Error()) + } + + dsRegexMap := map[tc.DeliveryServiceName][]tc.DeliveryServiceRegex{} + for _, dsRegex := range dsRegexes { + sort.Sort(DeliveryServiceRegexesSortByTypeThenSetNum(dsRegex.Regexes)) + dsRegexMap[tc.DeliveryServiceName(dsRegex.DSName)] = dsRegex.Regexes + } + + remapConfigDSData := []atscfg.RemapConfigDSData{} + for _, ds := range filteredDSes { + if ds.ID == nil || ds.Type == nil || ds.XMLID == nil || ds.DSCP == nil || ds.Active == nil { + continue // TODO log error? + } + // TODO sort by DS ID? the old Perl query does, but it shouldn't be necessary, except for determinism. + // TODO warn if no regexes? + for _, dsRegex := range dsRegexMap[tc.DeliveryServiceName(*ds.XMLID)] { + remapConfigDSData = append(remapConfigDSData, atscfg.RemapConfigDSData{ + ID: *ds.ID, + Type: *ds.Type, + OriginFQDN: ds.OrgServerFQDN, + MidHeaderRewrite: ds.MidHeaderRewrite, + CacheURL: ds.CacheURL, + RangeRequestHandling: ds.RangeRequestHandling, + RemapText: ds.RemapText, + EdgeHeaderRewrite: ds.EdgeHeaderRewrite, + SigningAlgorithm: ds.SigningAlgorithm, + Name: *ds.XMLID, + QStringIgnore: ds.QStringIgnore, + RegexRemap: ds.RegexRemap, + FQPacingRate: ds.FQPacingRate, + DSCP: *ds.DSCP, + RoutingName: ds.RoutingName, + Pattern: util.StrPtr(dsRegex.Pattern), + RegexType: util.StrPtr(dsRegex.Type), + Domain: util.StrPtr(serverCDNDomain), // note this is intentionally the CDN domain, not the DS or Server Domain. Must be the remap domain. + OriginShield: ds.OriginShield, + ProfileID: ds.ProfileID, + Protocol: ds.Protocol, + AnonymousBlockingEnabled: ds.AnonymousBlockingEnabled, + Active: *ds.Active, + }) + } + } + + serverProfileParams, err := GetProfileParameters(cfg, server.Profile) + if err != nil { + return "", errors.New("getting profile parameters from server (profile '" + server.Profile + ": " + err.Error()) + } + + serverPackageParamData := map[string]string{} + for _, param := range serverProfileParams { + if param.ConfigFile != "package" { // TODO put in const + continue + } + + if param.Name == "location" { // TODO put in const + continue + } + + paramName := param.Name + // some files have multiple lines with the same key... handle that with param id. + if _, ok := serverPackageParamData[param.Name]; ok { + paramName += "__" + strconv.Itoa(param.ID) + } + paramValue := param.Value + if paramValue == "STRING __HOSTNAME__" { + paramValue = server.HostName + "." + server.DomainName // TODO strings.Replace to replace all anywhere, instead of just an exact match? + } Review comment: Yeah, we need to refactor all the config generation, they're all an overly-complicated mess, and I'm not sure half the logic is right. Just hoping to do that in a separate PR, for safety. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
